Conversation
TobiGr
added
bug
Member
|
It also fixed #5475, thank you! I edit the PR body in order to close the issue when this is merged. |
TobiGr
force-pushed
the
dev
branch
2 times, most recently
from
679bc75 to
2aeccc0
Compare
Stypox
approved these changes
Mar 17, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
This was probably caused by my refactoring of the player. I tested this and it works. Looks good, thanks :-)
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 22, 2021
…yer_title Fix empty stream title in minimized player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes empty stream title in mini player info when a stream is started through background player and title of previous stream shown instead of title of the current stream.
Fixes the following issue(s)
Closes #5475
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence